[pwc] Preserve user setting for another program

[Daniel Hiepler]

Vom: Fri, 14 Dec 2007 10:14:27 +0100

Hi,

i had the same problem with the reset of brightness/agc.

> > look at pwc-if.c :
> > 
> >          /* Initialize the webcam to sane value */
> >          pwc_set_brightness(pdev, 0x7fff);
> >          pwc_set_agc(pdev, 1, 0);
> > 
> > and delete that pwc_set_agc line, and perhaps the other one, too. I
> > didn't try it, but a while ago, I did help someone about this: I
> > told him to try this and he said it worked.

I attached a patch that does it a bit cleaner. It adds a "no_reset"
module-parameter. If the driver is loaded with "no_reset=1" then the
reset is skipped and the camera settings are preserved over multiple
pwc_video_open() calls. The default is to stuck to the old behaviour
although i don't think it would cause trouble otherwise. You can decide
about that better.

> the line mathieu mentioned worked for me with the little side effect,
> that the led doesn't turn off after the device isn't used anymore. 
> 

I doubt this is related to pwc_set_agc() not beeing present and I don't
share your experience (using ID 046d:08b0 Logitech, Inc. QuickCam 3000
Pro [pwc])

If there is a relation one could save the agc-setting module-wide and
re-initialize the previous state in pwc_video_open()

Please include the patch (or alike) since with such a reset the driver
is unusable for me (and i guess a bunch of others, too ;)


best regards

-- 
rigid

Keep your boss's boss off your boss's back.

PGP Key available.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pwc-10.0.13-no-reset.patch
Type: text/x-patch
Size: 733 bytes
Desc: not available
Url : http://lists.saillard.org/pipermail/pwc/attachments/20071223/92ac3b14/attachment.bin